TOLOGIX - ISLG App Rebuild

UPDATED - Actions Menu

Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

We have attached updated assets for issues in the header, however all the dropdowns within the content of those pages work in our templates. Please take a closer look at their markup vs. what we have in the templates and make sure it matches, as there is nothing we can do from our end to resolve this. Once you have implemented the new CSS, we can have a call to discuss issues might be having.

Here are the updated files for the Actions Menu:



Templates:

http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/terms-phrases.html
http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/article-citator.html
http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/dispute-documents.html

Savannah

Comments & Events

Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We have checked with your above JS file and still issue occurred.

I think in your template the action menu is old.

The new action menu style is as per following screen shot.



We are using this action menu in all research tools.

Please use this above style action menu and check the action menu in compact view in all research tool.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We checked with your updated JS file in our local environment but still issue is there.

Could you please check with replace the action menu as per above screenshot and provide that html template again so we can check and compare.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Here is a file containing the function so you can implement it into your code.

Please let me know if you are still having issues.

Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah Melissa Cowell, General Manager at Industrial Melissa ,

I am not going to use above drodown.js function until we get confirmation from Stephanie side.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ​,


Could you please confirm that dropdown.js function  need to integrate or not?

Or there is change in AC template?
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We have found so many issue after integrated new JS and CSS file.

The Filter popup is overlapping in JC. In your template you don't have data so you can not find that issue.


Also, Due to following function in JS file, we are not able to load the data in PC, SN & TP module.

//$('.item-list').each(function () {
    //    dropdownCount++;
    //    var dropdownIndex = dropdownTotal - dropdownCount;
    //    $(this).css('position', 'relative');
    //    $(this).css('z-index', dropdownIndex);
    //});

In previous version of JS the above function was not avilable that time it works. but in new js file, due to above function the data is not loading in PC, TP and SN tool.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Also, still there and overlapping issue in action menu. Today we have call with Melisa and Naomi at 8:30 AM Ottawa time. 

IF possible then please join with your developer so we can discuss over call.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

We've taken a look at the templates. The overlapping issue is occurring because you removed the functions we wrote to fix it. We understand you removed them because they were preventing your data from loading.

We recommend generating the z-indexes on the elements in the templating language you are using, and remove the need for JS to generate them. This method will be far more effective than anything we provide using JS. 

Savannah 
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We are not able to understand how we will do at template level. IF you do at common JS level then it will be good for us so we don't want to go each tool template and change it.

Please clarify how we can achieve this ?

We are ready to take call with your developer and resolve this thing.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

Are you free for a call tomorrow (Tuesday, Aug. 18) at 9am Ottawa time?

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We are available today 9:00 AM Ottawa time. Please send invitation details.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Due to medical emergency in my relative, I am not able to take call today. 

Can we take call tomorrow (19/08) same time (9:00 AM Ottawa time ) ?
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

No problem. I rescheduled it to Friday. 
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

Here are the updated files for the action menu: 
http://tologix-islg-subscribers.s3.ca-central-1.amazonaws.com/publication-citator-devit.html

 
I adjusted the JS file and I added DevIT template to AWS. In this new JS file, I added some classes to the function that makes the z-index work. I saw that these classes aren't used in other templates for the same elements in devIT app. For example, in their Jurisprudence Citator Template, DevIT is not using the same class for the "Specific References" container. It would be important for DevIT to use the same classes across the application for our functions to work everywhere. 
 
The classes I added to our function are .specific-references > .card--details and .all-references > .card--details
 
Before testing the page above, clear your cache. 

Please test this before our call at 9am if you have time so you can let us know if you encounter any issues. 

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah and Kevin Andrews, Industrial Kevin ,

By using updated JS, The issue is resolved for JC & PC tool but for SN, AC, TP & DD tool the issue is still there.

Actually, We have found that the hierarchy which you used in JS file is work for JC & PC tool.



$('.item-list > .card--details, .specific-references > .card--details, .dropdown__content > .card--details, .all-references > .card--details').each(function () {
        dropdownCount++;
        var dropdownIndex = dropdownTotal - dropdownCount;
        console.log('test' + dropdownCount);
        $(this).css('position', 'relative');
        $(this).css('z-index', dropdownIndex);
    });

But, same hierarchy is not same for other research tool. Hence, if we apply specific-reference or all-reference class on those tool but still action menu overlap issue is not resolved.


Also, The bug which produced by Naomi  in Publication Citator,(https://industrialagency.tpondemand.com/restui/board.aspx?#page=board/5596457270758793748&appConfig=eyJhY2lkIjoiNEIyRDU0NTZFNkFEOUY1MUQwQzA5QzI5QjBBNjM1OTMifQ==&boardPopup=bug/17318/silent)

The overlap issue as per following screenshot in action menu is still there for all tools.




Please suggest.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

The new single Search for JC tool after merged latest CSS looks as per following screen shot.

Please confirm that is it OK ?


Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

You need to use the same classes as used in the JC and PC tool. 

And for single search, that's not quite right. We will be in touch regarding how to proceed. 
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We have used same class for other tool but the template is not set as per PC & JC. Hence, It is not working.

Could you please test in your template and provide the template for AC, SN, TP & DD for same ?

We have call tomorrow with Melisa and Naomi. so your developer can join then we can talk over call.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

I have added our developer to the call tomorrow. 


For the drop down menu, please follow the template we provided here: 
http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/jurisprudence-citator.html

You'll see that you're missing some padding around the search suggestions and the font weight is incorrect. Also, please make sure the behaviour is single select, not multi. 

Thanks

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

We did one minor change in our css and the search suggestion for single select is working as per our expectation.


Regarding, Action menu, we will talk with your developer today and let you know.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

The HTML Files you gave us for Subject-Navigator, Term and Phrases and Dispute Document were incomplete because some of the element are loading in AJAX. We did our best to figure it out from what you have on the app.
 
Article Citator HTML was complete. You can see on this example that it's fixed: 
http://tologix-islg-subscribers.s3.ca-central-1.amazonaws.com/devit-article-citator.html

Let us know if you have any questions or encounter any other issues. 

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ​,

Could you please able to tell what we need to change for Article citator template?
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

The above JS file we integrated in application and it works for Article Citator template.

Now, The Subject Navigator, Term & Phrase, Treaty & Rule and Dispute Document tool is pending to resolve action menu issue.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

After integrated above js file we found that, The Subject Navigator and Term & Phrase action menu is not working due to run time calculate the z-index and it is causing us in development.

If we going to click the Action menu then it is not working due to Z-index applied on those action menu.

Please update us as soon as possible that how we can resolve the issue.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

I have updated the files under actions menu at the top of this thread so they are easier for you to access.

We have tested what we can on our end. Please let us know if there are issues once you've implemented and perhaps we can discuss on our Monday morning call.

Savannah

CC Morgan Maguire, CEO Morgan  
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ​,

Thanks. We need to replace both JS and CSS file?

Could you please attache the files with send separate message again  in this thred. so will take those files only.
Harsh Parikh, Tech Lead at DevIT
Thanks Savannah Mitchell, Project Manager at Industrial Savannah ​. We will migrate those files before our monday call and will do primary testing. if any thing we find then will let you know.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Due to Priority of this issue, Today, We integrated above attached JS file and CSS in application and the our major issue of z-index which was blocked us to open accordion in SN and TP is resolved.

But, We found still some issues in Action Menu while we compact the card. Particular this issue only occur in AC, TP and DD module and header action menu of application.

This thing is not blocking us for next release but please look into this and resolve it.

Following, I have attached the Screenshots and video for your reference.

Savannah Mitchell, Project Manager at Industrial
Thank you Harsh Parikh, Tech Lead at DevIT Harsh . Kev will work on this this week and I will keep you updated on our progress. 

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Any update on this ? Due to this issue, 2 cards are in blocked state of Term & Phrase module. 
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

This original thread was updated on October 8th with the updated files and CSS. We aren't experiencing any issues on our end so please double check that you are implementing them correctly once you update your files (above, in original message). 

Let us know if you have any issues, 

Savannah
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Could you please attached that CSS and JS file in this thread ? so we can integrate and check it.
Savannah Mitchell, Project Manager at Industrial
No problem  Harsh Parikh, Tech Lead at DevIT Harsh , the message is at the top of this thread but it is copied below:

Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

We have attached updated assets for issues in the header, however all the dropdowns within the content of those pages work in our templates. Please take a closer look at their markup vs. what we have in the templates and make sure it matches, as there is nothing we can do from our end to resolve this. Once you have implemented the new CSS, we can have a call to discuss issues might be having.

Here are the updated files for the Actions Menu:



Templates:

http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/terms-phrases.html
http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/article-citator.html
http://tologix-islg-subscribers.s3-website.ca-central-1.amazonaws.com/dispute-documents.html
Harsh Parikh, Tech Lead at DevIT
OK Thanks Savannah Mitchell, Project Manager at Industrial Savannah . We will integrate the CSS file and let you know if we face any issue.
Harsh Parikh, Tech Lead at DevIT
Hi Savannah Mitchell, Project Manager at Industrial Savannah ,

Does the JS file required any changes or did you change anything in Template level in Term and Phrase ?

We integrated only CSS file but it is not work in our side.

Please suggest.
Savannah Mitchell, Project Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

No changes were made to the JS. If you are still having issues please provide videos and which files you are working with. 

Savannah