TOLOGIX - ISLG App Rebuild

Ability to extract a Provision List directly from HTML document

Hi everyone,

Following up on our meeting this morning and the item 1078 in ISLG Sprint 7: https://dev.azure.com/tologix/ISLGRebuild/_sprints/backlog/ISLGRebuild%20Team/ISLGRebuild/Sprint%207?workitem=1078, we will proceed as follows:
  1. Paul Moon Paul and Irit Weinfeld Irit will provide Harsh Parikh, Tech Lead at DevIT Harsh with a PDF sample (short treaty document).
  2. Harsh Parikh, Tech Lead at DevIT Harsh will convert the document with the automated converter and send Paul Moon Paul and Irit Weinfeld Irit a copy of the HTML.
  3. Irit Weinfeld Irit will send the sample PDF and HTML to CDS and request that they manually generate the HTML from the PDF, following the HTML tagging schema used for Dispute Documents, but will the additional guidance of the automatically converted HTML document provided by Harsh Parikh, Tech Lead at DevIT Harsh . Irit Weinfeld Irit , please ensure CDS returns the document back as a high priority.
  4. CDS will create the manually generate HTML document
  5. Harsh Parikh, Tech Lead at DevIT Harsh and team will use the manually generated HTML document to build and test the manual provision extract tool within the new ISLG application.
Please let me know if I'm missing anything.

Thanks,

Morgan

Comments & Events

Morgan Maguire, CEO
Thanks Irit Weinfeld Irit .

Do we have another that is better quality? I'm concerned these will have issues with the automated converter when Harsh Parikh, Tech Lead at DevIT Harsh attempts to create a sample HTML.

Thanks,

Morgan
Morgan Maguire, CEO
Great. Thanks Irit Weinfeld Irit !
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan , Martin Laporte, CTO at Tologix Martin and Irit Weinfeld Irit ,

I have uploaded one sample Treaty PDF document on staging.islg and converted into html through our application so the provisions are automatically added into database.

Now, we need to provide this same html document to CDS team so they can make further Treaty & Arbitration html by using this sample html file as reference.

You can forward this attached html file to CDS team to take this html as reference.

Morgan Maguire, CEO
Great. Thank Harsh Parikh, Tech Lead at DevIT Harsh .

However, I noticed that the HTML document above does not have all the structure we want it to. For example, Chapter I is created as a standalone <div> tag and does not indicate that Rules 1-12 are all contained within Chapter I:

Martin Laporte, CTO at Tologix Martin and Harsh Parikh, Tech Lead at DevIT Harsh , I assume this is something that CDS could manually integrate into the HTML documents when they code them?

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Yes Morgan Maguire, CEO Morgan , you are correct. The class name Provision is important to make in div element. for example  if there is any div element then we apply class="provision and div tag Id as per following example.

Rule 1 is div tag in html then  class="provision" and id need to apply for Rule 1 div tag ( <div data-pro='RULE2' data-key='32' class='para paralvl1 provision' id='BIT1365_paRULE2.1'>)

I will discuss with Martin in today's call so he can guide or discuss with CDS team.
Martin Laporte, CTO at Tologix
Hi Irit Weinfeld Irit ,

Can you ask CDS to start converting the 2 documents you have posted in this thread?
They should use the following items to guide them:
  • Harsh's converted HTML document posted in this thread (as an example document)
  • Harsh's latest comment about using the class name "Provision"
  •  The HTML coding manual 

While CDS works on converting the documents, Harsh Parikh, Tech Lead at DevIT Harsh will continue coding ISLG Admin so it can extract the Provision List from a manually converted HTML doc. Our goal is to then use the documents manually coded by CDS to test against the new code.

Could CDS turn these documents within 1 week (or less)?

Also note that after this project is complete, we will probably need to make small adjustments to our HTML coding manual.

Thanks,
--Martin
Irit Weinfeld
Hi Martin Laporte, CTO at Tologix Martin ,

Yes, I will send an email to CDS today.  I'll let them know this is high priority and we need this back within a week or less as you suggested. 

Thanks,
Irit
Morgan Maguire, CEO
Thanks Irit Weinfeld Irit . Could you please cc Martin Laporte, CTO at Tologix Martin and myself on the email to CDS.

Morgan 
Irit Weinfeld
Morgan Maguire, CEO Morgan , yes.  An email was sent to CDS today.

Thanks,
Irit
Morgan Maguire, CEO 👍
Morgan Maguire, CEO
That's great. Thanks Irit Weinfeld Irit .

Harsh Parikh, Tech Lead at DevIT Harsh , I assume these will work in providing you the sample documents you need?

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan , Irit Weinfeld Irit   and Martin Laporte, CTO at Tologix Martin ,

We checked the html and found that there is spelling mistake in html for provisionDefinition class.

As per following screenshot, there is spelling mistake.


In Red box, you can see the spelling of provisionDefination.

Please ask to CDS team to correct the spelling in both html and revert back to us.

The correct word is : provisionDefination

The provisionDefination is use for  fetch the title of provision.
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan and Irit Weinfeld Irit ,

Harsh Parikh, Tech Lead at DevIT Harsh and I had a discussion this morning. For these 2 documents, Harsh Parikh, Tech Lead at DevIT Harsh will make the changes himself (so there will be no need to have CDS do them), but we will also need to inform CDS of the class name change.

There is a typo in "provisionDefination", but this is the way it was coded in our code, so unfortunately this is what CDS will need to use moving forward.

Harsh Parikh, Tech Lead at DevIT Harsh will be updating the HTML Coding Manual to add a new "Provision" part and explain this.

Morgan Maguire, CEO Morgan : can you confirm that the latest copy of the HTML Coding Manual is the one I have attached?

Thanks,
--Martin
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Irit Weinfeld Irit ,

Today, We have deployed this task on staging.islg. You can check and provide your feedback.

When you select Edit Provision from Dropdown menu then you can get button for Provisions.

You can use following 2 attached html files for fetch the provisions. As per Martin above comment, We replace the spell and update the following 2 HTMLs. 
Morgan Maguire, CEO
Hi Martin Laporte, CTO at Tologix Martin ​,

Yes, that's the latest version of the coding manual. Note all the coding manual versions are contained here: https://islg.egnyte.com/fl/9VgmHKWgaz.

Does this mean we're stuck with that typo?

Thanks,

Morgan
Morgan Maguire, CEO
Great. Thanks Harsh Parikh, Tech Lead at DevIT Harsh ​.

Irit Weinfeld Irit ​, could you please test this on staging and report back the results.

Thanks,

Morgan
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan ,

We are stuck with this typo for the time being. Harsh Parikh, Tech Lead at DevIT Harsh and I discussed the effort required to make the change. While the effort is not huge, several parts will be affected.
One of these parts is the PDF to HTML conversion engine. Since we are in the midst of upgrading our conversion engine, I think the best approach is to make that change at the time when we do the official switch to the new engine.

Thanks,
-Martin
Morgan Maguire, CEO
Ok. Sounds good, Martin Laporte, CTO at Tologix Martin ​. Makes sense.

Morgan
Irit Weinfeld
Hi Morgan Maguire, CEO Morgan , Martin Laporte, CTO at Tologix Martin Harsh Parikh, Tech Lead at DevIT Harsh  

Success. I uploaded the HTMLs for BIT/0916 and BIT/0917 on staging.islg. I then selected the Get Provision button.  The provision list was pulled from the HTML. 

Please let me know if you would like for me to confirm this on DevOps and if I need to change the state to “Tested on Staging”.  

Thank you,
Irit
Morgan Maguire, CEO 👍
Martin Laporte, CTO at Tologix
Hi Irit Weinfeld Irit ,

Great! Yes, please change status to "Tested on Staging" if you are satisfied with the functionality.

Thanks,
--Martin
Irit Weinfeld 👍
Harsh Parikh, Tech Lead at DevIT
Hi Martin Laporte, CTO at Tologix Martin ,

Here, I have updated user manual for Treaty and Arbitration html documents. You can find the update in second page. I marked out as grey color.




you can update the text or content if you want.
Martin Laporte, CTO at Tologix
Hi Harsh Parikh, Tech Lead at DevIT Harsh , thanks. I reviewed the changes and they look good to me.

Hi Irit Weinfeld Irit : can you share the latest document with CDS? Note that I have also uploaded a copy to our Egnyte share (\Shared\ISLG\Database Development & Maintenance\ISLG Rebuild\HTML Coding).
Thanks!

CC: Morgan Maguire, CEO Morgan  
Irit Weinfeld
Hi Martin Laporte, CTO at Tologix Martin ,

Will do, thanks.
Irit
Morgan Maguire, CEO
Perfect. Thanks everyone!

Morgan