TOLOGIX - ISLG Maintenance

Project dealing with all ongoing maintenance of the current ISLG application (www.investorstatelawguide.com and dev.investorstatelawguide.com).

Problem with sorting results by passages most frequently cited

Assigned to
Anil Vaghela Anil V. Harsh Parikh, Tech Lead at DevIT Harsh P. Ryan Knuth, Customer Support Manager at Industrial Ryan K.
Due on
Notes
Further to the video below, there is an intermittent problem with the sorting results by passages most frequently cited in the Article Citator. The examples used in the video are the following:

https://www.investorstatelawguide.com/ResearchTools/ArticleCitator?toc=content&id=201&cat=&subcat=&docid=809&AgreementID=110&ProvCode=Art25.(2)&aaprovid=51765&randomno=92&aaNodeID=&sort=mf#ACit
https://www.investorstatelawguide.com/ResearchTools/ArticleCitator?toc=content&id=201&cat=&subcat=&docid=57&AgreementID=73&ProvCode=Art31&aaprovid=40952&randomno=10&aaNodeID=&sort=mf#ACit

These are just two examples, but I suspect there are a number of other examples. When performing the fix, can you please confirm that the issue is resolved across the entire system.


Comments & Events

Morgan Maguire, CEO
In additional to the notes above, there is an additional issue that needs to be addressed concerning documents that require manually inserted short codes and paragraph descriptions. Further to the video below, for documents that required manually inserted short codes and paragraph descriptions, the system needs to recognize and covert short codes into the appropriate paragraph descriptions when displaying the applicable results in the Jurisprudence Citator. The examples used in the video are the following:

Document with manually inserted short codes and paragraph descriptions: https://www.investorstatelawguide.com/CoreComponents/AddDocumentStep1?docId=1927
Document with Jurisprudence Citator entries referring to short codes for AF/0022/01: https://www.investorstatelawguide.com/CoreComponents/AddDocumentStep3Type4?docId=4793

I have added this comment under this to-do, because resolving this issue will also ensure appropriate cross references can be established between the Article Citator and Jurisprudence Citator to display results by passages most frequently cited under the Article Citator.

Thanks,

Morgan

Morgan Maguire, CEO
Hi Anil Vaghela Anil and Harsh Parikh, Tech Lead at DevIT Harsh ,

Has work begun on this to-do? It's been in the queue for a while, and it needs to be addressed. Also, in addition to the issues outlined above, the video below describes another instance where the manual destination codes are not working properly: Related Jurisprudence under the Article Citator. The example used in the video below is here: https://www.investorstatelawguide.com/CoreComponents/AddDocumentStep1?docId=1814 and here: https://www.investorstatelawguide.com/ResearchTools/ArticleCitator?toc=content&id=201&cat=&subcat=&search_title=algeria&catac=Bilateral%20Investment%20Treaties%20(BITs)&docid=58&AgreementID=222&ProvCode=Art1&aaprovid=62671&sort=&aaNodeID=&aaDisputeID=1320545&aa_docid=1814&agreementID=222#aa1814

Thanks,

Morgan


Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

We haven't started the development on this to-do. we will start the work very soon and will keep you updated.
Morgan Maguire, CEO
Sounds good. Thanks Harsh Parikh, Tech Lead at DevIT Harsh .

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

We are start working on this task and will update you soon.
Morgan Maguire, CEO
Great. Thanks for the update Harsh Parikh, Tech Lead at DevIT Harsh .

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Ryan Knuth, Customer Support Manager at Industrial Ryan ,

The above issue has resolved on dev.islg. Please check and let us know the feedback.
Ryan Knuth, Customer Support Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh

When testing Morgan's first issue, I'm now seeing two "Paragraph" links at http://dev.investorstatelawguide.com/ResearchTools/ArticleCitator?toc=content&id=201&cat=&subcat=&
docid=809&AgreementID=110&ProvCode=Art25.(2)&aaprovid=51765&randomno=61&aaNodeID=&agreementID=110&sort=mf#ACit



The manual destination code labelling seems to be working fine now. 

Thanks!

Ryan
Harsh Parikh, Tech Lead at DevIT
Thanks Morgan Maguire, CEO Morgan and Ryan Knuth, Customer Support Manager at Industrial Ryan ..

We are looking into it and will update you soon.
Morgan Maguire, CEO
Thanks Harsh Parikh, Tech Lead at DevIT Harsh .

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Ryan Knuth, Customer Support Manager at Industrial Ryan ,

We have resolved the initial requirements of this task on dev.islg. Please check and let us know the feedback.
Morgan Maguire, CEO
Looks great Harsh Parikh, Tech Lead at DevIT Harsh . Scheduling this for migration on Tuesday.

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Ryan Knuth, Customer Support Manager at Industrial Ryan ,

The bookmark issue on the manual destination codes has resolved on dev.islg.

Please check and confirm.
Ryan Knuth, Customer Support Manager at Industrial
Thank you, Harsh Parikh, Tech Lead at DevIT Harsh . Looks good to me on dev.islg.

Ryan
Morgan Maguire, CEO
Looks good. Scheduling this for migration on Tuesday.

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Ryan Knuth, Customer Support Manager at Industrial Ryan ,

This task has been migrated on www.islg. Please check and confirm.
Ryan Knuth, Customer Support Manager at Industrial
Thank you, Harsh Parikh, Tech Lead at DevIT Harsh . Looks good on www.islg.

Ryan
Morgan Maguire, CEO
Morgan Maguire completed this to-do.
Irit Weinfeld
I'll make this priority.  
Thanks,
Irit
Morgan Maguire, CEO
Thanks Irit.
Irit Weinfeld
Hi Morgan,
This task is complete.  All applicable JP Citator entries with references to documents that had special destination codes manually entered have been fixed on the Admin site.  I double checked them on the Live site as well.
Thanks,
Irit
Morgan Maguire, CEO
Perfect. Thank you for getting these completed so quickly, Irit Weinfeld Irit
Morgan Maguire, CEO
Morgan Maguire re-opened this to-do.
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

We are working on this task and will update you soon.
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

The above issue has resolved on both dev.islg and www.islg. Please check and let us know the feedback.
Ryan Knuth, Customer Support Manager at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh  

I've confirmed on both dev.islg and www.islg. Do you know how this issue came up again?

Thanks!

Ryan
Harsh Parikh, Tech Lead at DevIT
Hi Ryan Knuth, Customer Support Manager at Industrial Ryan ​,

There was a minor query issue. we haven't checked null value in query which we have resolved on both dev.islg and www.islg
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

I confirm that the issue is resolved on both dev.islg and www.islg. However, please confirm how the null value in the query was created. We need to ensure that issue doesn't occur again in the future.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

Due to some reason the data was inserted null only for particular this document. Hence, Query is considering all data in "All Citation".

Yesterday, we have again checked the whole code but all things are working perfectly.
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Thanks for clarifying. However, that sounds somewhat disconcerting. Is there any way for us to run periodic audits on this data to ensure other anomalies do not occur in the future?

Morgan 
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Just following up on my comment above. I want to ensure we're doing everything possible to prevent this from happening again, because this issue has appeared a number of times over the years.

Thanks,

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

We are looking into this how to prevent or put some checkpoints for this issues. We will update you soon.
Morgan Maguire, CEO
Great. Thanks Harsh Parikh, Tech Lead at DevIT Harsh .

Morgan 
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh and Anil Vaghela Anil ,

I'd like to get this to-do wrapped up. Any update on preventing this issue from reappearing again?

Thanks,

Morgan 
Morgan Maguire, CEO
Hi Anil Vaghela Anil and Harsh Parikh, Tech Lead at DevIT Harsh ,

Further to my comment above, this issue has come up again here: https://www.investorstatelawguide.com/ResearchTools/ArticleCitator?toc=content&id=201&cat=&subcat=&docid=56&AgreementID=79&ProvCode=Art31.4.&aaprovid=46153&randomno=83&aaNodeID=&agreementID=79&sort=mf#ACit.

Also, can you confirm this issue is not present elsewhere in the Article Citator, and how do we prevent this from happening again in the future?

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

There was a minor semi column bug we caught it programming. It means, if we enter semi column after Paragraph No. (E.g 474;) the blank entry entered in database. Temporary We have resolved through database on ww.islg. 

But, meantime we are doing change in programming and let you know once it will be completed.
Morgan Maguire, CEO
Sounds good Harsh Parikh, Tech Lead at DevIT Harsh . Let us know when the programming change has been completed, and we'll do another survey of results to make sure the issue is resolved.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

The programming change has been done and uploaded on dev.islg. Please check and let us know the feedback.

As an example, In Admin Side now if you will enter citation like "474;" then no blank row will be added in database.
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

The results on the front-end look good. Could you clarify the blank row issue though. Do we need to modify anything in the way we upload data into the Citators? Or is this resolved through the programming?

Thanks,

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

This issue has resolved through programming. You don't need to modify anything in way of uploading data.
Morgan Maguire, CEO
Great. Thanks Harsh Parikh, Tech Lead at DevIT Harsh . I'll mark this to-do complete.

Morgan
Morgan Maguire, CEO
Morgan Maguire completed this to-do.