✔ Problems with front-end search
Completed by Morgan M.
- Assigned to
-
Anil V.
Hiren P.
Ryan K.
Stefanie G.
- Notes
-
Further to the video below, the front-end search does not appear to be working according to the requirements
Thanks,
Morgan
Below is updated video concerning the issue in this to-do, there is still a fair bit of work that needs to be done here to ensure we have a functioning full text search for the front-end of the application.
Thanks,
Morgan
I found this story that talks about search. https://industrialagency.tpondemand.com/RestUI/Board.aspx#page=board/4857933491727658105&appConfig=eyJhY2lkIjoiOTk1NDg2NkUwM0I1RTJGMzQ5NjgyOTdFRjk2NkRGN0YifQ==&searchPopup=userstory/3410
I think originally it was intended that you would do either a keyword search or a tagged search. It does look like when you view entire document after selecting a keyword that is not also a tag, the document will load with keywords tagged (see below). So I think we should probably also be highlighting keywords (in the view entire document) even in when that keyword is also a tag. Would you like to add 'See all Keywords' as an option like viewing tagged highlights so that the user can jump from one keyword to the next?
The reason we added that second link is because previously all the user would see was 'no results for tag' and this looked like there were no results at all so we added a second link so that it was clear that you could still do a keyword search...otherwise the first thing you see is no results, making it unlikely you'd select the search button at all. If you want this changed back, let us know.
I understand. If that's the case, then we need to create a better way for users to view and distinguish between tag results and keyword results. Perhaps this can be done by including an option that forces the user to select tags vs. keywords when they enter the document, which would allows us to display keyword results in the same way we are displaying tags results (i.e., provide the ability to display both an excerpts view of keywords and an entire document view with the ability to browse through the highlighted keywords).
Thanks,
Morgan
Yes, I think we could treat this the same way we do tagged highlights. This means that it needs to have its own link from the listing and then within a document, it would need it's own excerpt view and it's own navigation. It would also need to be included in document comparison.
Let me know what you think.
Thanks,
Morgan
We will implement this and let you know.
We are assuming that when user will click on "View Keyword Excerpts", the entire document will be displayed with highlighted keywords. Using navigation feature user will able to navigate from one keyword to next keyword. Please clarify.
I think the keyword excerpts should be similar to how we display them in ISLG's Full Text Search (see screenshots below). The search terms will be highlighted with text around it to give the reader context on the result. In addition, the user should be able to select the excerpt to go directly into the full text where the excerpts keyword exists (i.e., easily jump between "view keyword excerpts" and "view entire document" without losing their place in the document). Perhaps a link above the extract as we provide in ISLG?
Thanks,
Morgan
On another note, we should probably change the links here to show which one is currently selected like below. Right now we're not doing this.
Note that this makes it imperative that we insert all the anchor codes for all provisions within a document, which adds an additional level of complexity to the HTML document building process.
Thanks,
Morgan
Morgan
Morgan
We have uploaded a beta version of above changes on p3lg. Please review and let us know the feedback.
This link will only come when you search using a keyword. This will not display when we select multiple tags.
Further to the video below, there are still a number of issues with the front-end search including:
Morgan
Morgan
For #4, I think what Morgan was saying was that he wants to eliminate the keyword excerpts and display the keywords just within the full text - but I could be wrong so let's wait until he gets back to confirm with him.
On another note, it does look like something has happened to the styling. Suddenly I'm seeing Times New Roman appearing:
Below thing is done on p3lg. Please review and let us know the feedback.
7. For keyword excerpts, when selecting view in entire document, it doesn't take the user to the appropriate place in the document, nor does it highlight the relevant keyword. - Done
Please note that we are still doing r & d on below issue but haven't find out anything yet.
3. For tagged excerpts, further work is needed to match the formatting in the HTML document.
I'm noticing something strange happening here for #7.
The text from the keyword excerpt and the text within the document don't seem to match. It does seem to be bringing me to the right location though. For your reference, I was viewing FL-0001-0001 - I-4 Ultimate - Concession Agreement Executed when I did a keyword search for convenience.
Keyword Excerpt
Opened in full document:
Keyword Excerpt
Opened in full document:
As you'll see, the numbers seem to change between the two.
There is some issue with PDF to html conversion for this file. We have regenerated the html file and now it works fine. Please check and confirm.
#1, #5 and #8 are working well.
#2: that ordering works for me.
#3: please continue with R&D.
#4: selecting the tagged excerpt is opening the entire document view, but not taking me to the relevant passage within the document where the excerpt is found with the text highlighted.
#6: understood. We can leave things as is for now.
#7: selecting "see keyword within entire document" is still taking me to random points in the document without the highlighted text. Note that I was using these examples:
http://p3lg.tologix.com/Home/ViewTagExcerpts?tagDocumentId=318&tagId=320&oper=key&keySearch=termination-for-convenience&keyCount=36
http://p3lg.tologix.com/Home/ViewTagExcerpts?tagDocumentId=417&tagId=320&oper=key&keySearch=termination-for-convenience&keyCount=12
Thanks,
Morgan
We have resolved issue #4. Please check and let us know the feedback.
Issue #7 is still pending, we will come tomorrow to look into it.
Further to the video below, issues #4 and #7 are partially complete. However, I discovered some other issues that need to be resolved:
Morgan
We have resolved both the issues you posted in above video. Instead of putting separate scroll bar for html document we have put a button on bottom-right to move to top. Please review and feedback.
We have also resolved the following issue of #7:
selecting "see keyword within entire document" is still taking me to random points in the document without the highlighted text. Note that I was using these examples:
For #4, I'm not getting scrolled to the tagged excerpt in Firefox for doc http://p3lg.tologix.com/Home/Search?tagId=0&tagIdList=320. It works fine in all other browsers.
#7 looks good to me.
Thanks!
Ryan
I still think a separate scroll bar would be better.
Also, I confirm
Thanks,
Morgan
If we were to keep that 'back-to-top' button, let's please add Top as a label to it.
As result, perhaps we should make the project/document details collapsed and expandable so that the sticky header doesn't take up too much of the screen? Similar to what we have in the tagging view on the admin site:
Thanks,
Morgan
If that would be too difficult, yes we could also provide this function to the user manually. Let me know your thoughts.
Also, it would be great if we could ensure the top level header (Home, Learning Centre, etc.) was always available across the entire members site.
Morgan
The issue for Firefox is resolved on p3lg. Please check and feedback.
Hello
The design you have proposed seems possible but it may take time. It would be great if
We have also started working on this fix header but need
Ryan
I did up a quick user story with a visual for how it should look in the scroll down position. I've added some instructions in here for kev too - Anil please let kev know where you're at and what you need when he gets back on Wednesday - Let
Here's the story:
https://industrialagency.tpondemand.com/RestUI/Board.aspx#page=board/4857933491727658105&appConfig=eyJhY2lkIjoiOTk1NDg2NkUwM0I1RTJGMzQ5NjgyOTdFRjk2NkRGN0YifQ==&boardPopup=userstory/5376
Thanks,
Morgan
There is one section project details between main menu and document navigation links. We think it would be easier if we can keep main menu as it is and rest of the links sticky. Please suggest.
We'd like to talk this through with
Melissa
Thanks,
Morgan
We have implemented sticky links (excluding header) on p3lg. Please check and let us know the feedback.
Ryan
The stickiness looks good; however, we'll let
Thanks,
Morgan
In order to have the main header sticky the height of the header will need to be offset in the position of the other sticky elements.
To make the header sticky add the following CSS
#headerDisplay{ position: fixed; top: 0;width: 100%;
z-index: 1000; }
Some Javascript will need to be added to detect the height of the header as it may change depending on the screen resolution. This height will be used to set the vertical offset of the other sticky elements. I would add this javascript wherever you're handling the sticky toggle of the other elements.
var headerHeight = $('#headerDisplay').outerHeight(); $(window).resize(function(){ headerHeight = $('#headerDisplay').outerHeight(); checkScrolled(); }); checkScrolled(); function checkScrolled(){ $('body').css('padding-top', headerHeight + 'px'); }
You can use the variable 'headerHeight' from the code above to set your vertical offsets on your other sticky elements. For example:
$('.scroll-fixed1').css('top', headerHeight + 'px'); $('.scroll-fixed').css('top', 50 + headerHeight + 'px');We added above scripts in our project and uploaded on p3lg. It seems good. Please check at your end and feedback.
You can also check this on p3dev from below URL:
http://p3dev.tologix.com/Home/ViewTagExcerpts?tagDocumentId=440&tagId=360,362,364,363&oper=doc&keySearch=notice&keyCount=226
Looks good on desktop, just needs 1 fix for mobile:
Similarly to how we are detecting the vertical offset of the main header, we will need to offset "Tagged Highlights/Keyword Highlights" by the height of the main header + red links
headerHeight = $('#headerDisplay').outerHeight(); // Include a script to detect the height of the red links container hereand then change the line where we set the offset to include the dynamic height of that container.
$('.scroll-fixed').css('top', redlinksHeight + headerHeight + 'px');Hello
We have updated above scripts on p3Dev, navigation links are overlapped with the document text. Please check below URL:
http://p3dev.tologix.com/Home/ViewTagExcerpts?tagDocumentId=440&tagId=360,362,364,363&oper=doc&keySearch=notice&keyCount=226
I'll
Morgan
Thanks,
Morgan
We have done this change on p3lg. Please check and feedback.
Morgan