Hi Morgan , Melissa and Naomi ,

We need specific requirements or user story to cover this task so please provide criteria directly on Azure Devops. 

Hi Harsh , Melissa and Naomi ,

Paul , Irit , Martin and I had a discussion about this issue, and we decided that we would like to deal with this issue as follows:

We understand that this request has the potential for significant technical and design challenges. As a result, I propose that Irit  and  Paul have a meeting with Naomi to describe the changes we need and then Naomi  draft requirements that will create the least significant changes to the UI of the application.

Hi Morgan , Paul and Irit ,

That sounds like a good idea to have a meeting and discuss the issue in more detail. Is anytime Thursday after 1pm EST available? 

Thanks, 

Naomi

Sounds good, Naomi . Does 1:30pm EST (10:30am PST) work for everyone?

Morgan 

1:30pm EST works for me.

Yes, 10:30 a.m. PST works for me on Thursday.

Thursday 1:30pm EST works for me as well.

Hi Morgan , 

This is what I captured from today's call:

Considerations:

Let me know if there is anything else that should be added there. Would you like us to schedule a call to discuss further with devIT, and if so who should be there?

Thanks, 

Naomi

Perfect. Thanks Naomi .

Martin and Harsh , could you please discuss the considerations Naomi has highlighted above during your next meeting and we'll determine next steps based on the technical constraints.

Thanks,

Morgan

Hi Naomi , Morgan and Martin ,

Following my answers for your questions.

After Publish the document, We can allow functionality to replace the PDF file but we can not replace the html file due to tagging functionality. Also, we need to check certain parameters like Document is published and admin create the draft version and then admin will replace the PDF file in Published version then what will affect on draft version PDF ?

We Should not allow to edit the text after publish the document as if admin user by mistake remove any element from html file or remove any Id or data-key then it will affect the tagging data. But we can discuss what admin user want to edit in html file and will find another way to achieve this functionality.

Hi Harsh ,

Your answers above don't address the specific issues we're asking about. I've clarified the issues further below: 

After Publish the document, We can allow functionality to replace the PDF file but we can not replace the html file due to tagging functionality. Also, we need to check certain parameters like Document is published and admin create the draft version and then admin will replace the PDF file in Published version then what will affect on draft version PDF?

The issue is that there is a difference in what can be edited between documents that were migrated to the application from the legacy application and documents that were manually uploaded into the application. We want to resolve this and ensure that all the migrated documents have all the editing functions (including replacing the PDF).

We Should not allow to edit the text after publish the document as if admin user by mistake remove any element from html file or remove any Id or data-key then it will affect the tagging data. But we can discuss what admin user want to edit in html file and will find another way to achieve this functionality.

We understand the risk and limitations in editing the HTML file within the application; however, the key issue we want to understand is whether there is are technical limitation that prevents us from making minor edits (e.g., correcting typos) to the HTML after tagging has been added to the document. Does tagging the document alter the document in any way that prevents us from making these minor edits to the HTML?

Could you please comment further on these issues.

Thanks,

Morgan

image.png 15.7 KB • Download

Hi Harsh ,

From Morgan's message above, here is an example of a design limitation for migrated files.  In the UIN Master List sent for Migration (dated 3 December 2020), Grey highlighted BITs and Treaties were part of the migration. They were uploaded as Placeholders.

image.png 44.6 KB • Download

We are able to change the Placeholder toggle button from "Yes" to "No":

image.png 2.05 KB • Download

However, we are NOT able to upload PDFs or HTMLs.  Currently, we send a Basecamp request to DevIT to upload the PDF and HTML for these BITs and Treaties.

Treaties that we upload internally as Placeholders do not have this same issue.

Thanks,
Irit

Hi Irit , 

Is this the only issue? If so, we can deal with this separately, because I don't think it affects the proposed changes above.

Morgan

Hi Morgan ,

Yes. And yes, this can be dealt with separately. 

Thanks,
Irit

Ok. Thanks Irit ​.

Harsh ​, can you please comment on my second comment above then?

Thanks,

Morgan

Hi Morgan ,

The typo correction you can do but if any admin user by mistake add/remove something then might be it will create issue.

The issue is not creating for tagging saved data. The issue will create to load the tagging in html document.

Hi Harsh :

ISLG legacy admin site currently has a XML preview function where admin users could make minor changes (e.g., typo) and view the XML before publishing the changed XML.

Would it be possible to build something similar to HTML on app.islg where admin users are required to preview the edited HTML to ensure nothing is added or removed that may upset the whole HTML? If the preview function shows an error, admin users will contact you instead of proceeding with the change.

Thanks,

Paul

Hi Paul ,

Further to Irit 's comments above, could you please confirm that the placeholder issue is the only issue that differentiates migrated documents and manually uploaded documents (Note we need to confirm whether there any other differences with Disputes, Dispute Documents, Treaties, Arbitration Rules and Non-Investment Treaty Dispute Documents), because these could potentially affect the requirements that Naomi writes to implement this to-do.

Thanks,

Morgan

Hi Morgan :

I'll confirm with Irit again to think of any other examples and report back here.

Thanks,

Paul

Hi Harsh ,

Following-up on above and our discussion last Thursday, could you confirm whether it is possible to make edits to HTML text that has been tagged in analysis. As we discussed, the edits would be limited to correcting minor issues (e.g., typo) and would not affect the paragraph IDs within the document. Please confirm whether such edits are possible post analysis (and any technical limitations) so that we can start writing the requirements relevant to this to-do.

Thanks,

Morgan

Hi Martin :

Could we follow up with this item? These issues affect Irit Nafiseh on a daily-basis. I know there are a lot of issues discussed, so we can break it further to actionable items if necessary.

Thanks,

Paul

Hi Paul ,

With our current setup, there are definite risks associated with the Content team editing documents that have already been tagged.

There are 2 ways we can tag:

Looking forward into next year, I think we could improve our HTML editor tool, so it is smart enough to adjust the tag coordinates (when dealing with scenario #2 above) whenever an admin makes a text edit. That is likely the be a complex project, but it is definitely possible to accomplish.

Thanks,
-Martin

CC: Harsh  

Hi Paul ,

The above task is completed and uploaded on staging.islg. Please check and confirm.

https://dev.azure.com/tologix/ISLGRebuild/_workitems/edit/259

cc: Martin Harsh  

Hi Nafiseh and Irit :

Please check this new feature on staging.islg admin and report any feedback here. If all looks good, we can proceed to deployment.

Nafiseh : Irit can guide you if you are unsure about the new implementation.

Thanks,

Paul

Hi Paul and Piyush ,

I checked this new feature on staging.islg admin. It looks good to me. However, as you see in the videos below, there seems to be a bug as for "Generally" references:

Unable to edit excerpts and analysis data - Generally references (1).MP4 6.53 MB • Download

Unable to edit excerpts and analysis data - Generally references (2).MP4 15 MB • Download

1- I am not able to remove one (or some) of the paragraph numbers under "Paragraph(s) of Document Referenced" when "Generally" is selected under Article/Provision.

image.png 44 KB • Download

I get the following message: "Legal Instrument and Article/Provision is already exists."

image.png 62.3 KB • Download

2- I am not able to change specific references to "Generally" reference as  I get the following message: "Legal Instrument and Article/Provision is already exists."

In the example of BIT/0004, I first made sure that Generally reference has not been already entered.

image.png 52.9 KB • Download

When I tried to change the specific reference (Article 7(2)) to a "Generally" reference, I got the following message.

image.png 60.4 KB • Download

Thanks,

Nafiseh

Hi Piyush :

Please let us know when the two issues identified by Nafiseh are addressed.

Thanks,

Paul

Hi Nafiseh , Paul and Irit ,

The above issues are resolved on staging.islg.

Please check and confirm.


Cc : Martin  

Hi Harsh ,

Issue #1 is resolved, but as you see in the video below, issue #2 is not resolved yet.

Unable to edit excerpts under analysis list (feedback).MP4 13.7 MB • Download

Could you please look into it?

Thanks,

Nafiseh

Hi Nafiseh ,

This is not bug.

As per our discussion, We have finalized that if there is same source data while you update tagging data then will display warning message that this kind of data already available in Analysis List. Please go through it and update there.

For example in your case AC UIN BIT/1223 and Provision Generally already available in Analysis List. so find out that data and update there.

If you have any concern then please contact Paul or Irit so they will guide you.

Cc : Martin  

You are right, Harsh . That was not a good example to check the issue. I checked a few other entries, and they function correctly.

Thanks,

Nafiseh

Hi Nafiseh :

If everything else looks good, please complete this item.

Harsh : when Nafiseh   marks this item complete, please deploy it to app.islg.

Thanks,

Paul

Hi Paul ,

Yes, it looks good to me.

Irit , could you please confirm if everything looks good for Subject Navigator as well, so I could l mark this to-do as complete?

Thanks,

Nafiseh

Nafiseh Paul ,

Everything looks good for SN.  
Irit

Hi Irit ,

You have re-open this item. Do you find any issue ?

Cc : Paul Martin Piyush  

Hi Harsh ,

No issues.  I will mark this to-do as complete.
Irit