TOLOGIX - ISLG App Rebuild

Erroneous admin override message

Assigned to
Harsh Parikh, Tech Lead at DevIT Harsh P.

Comments & Events

Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Could you please address this as an Unplanned/Critical task. Also, if this is user error, could you please why.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Paul Moon Paul ,

I checked and found that there is name in database that Gonzalo A Salazar Lizausaba has open that dispute on 25th August 2021. Hence, his name is show in Dispute UN/0300.

If you want to remove his name then let us know so we can remove his name from UN/0300.

Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Does this mean that because Gonzalo opened the dispute on August 25th and did not exit the document properly, it has stayed open in editing mode since that time?

If that's the case, we need to come up with a solution that prevents this from happening and automatically saves the document and checks it back into the database so that it can be edited.

Martin Laporte, CTO at Tologix Martin , could you discuss this with  Harsh Parikh, Tech Lead at DevIT Harsh and come up with a proposed solution.

Thanks,

Morgan
Martin Laporte, CTO at Tologix
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Let's discuss this topic during our Tuesday meeting.

Thanks,
--Martin
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan and Paul Moon Paul ,

You are correct that Gonzalo did not exit the document properly. He probably exited the application by closing the tab or the browser. There is no reliable way for our code to catch such an event.

There are 2 potential ways to deal with this:
  1. We add a new button directly on the Admin page that would allow a user to "force remove" the name.
  2. We run a regular SQL job that looks for situations like this one, and automatically removes the name when found.

I personally prefer #1, as we have a better control over the process.

Thanks,
--Martin
Morgan Maguire, CEO
Understood. Thanks Martin Laporte, CTO at Tologix Martin . Could you please add the agenda for today's team meeting, and we'll decide on the appropriate solutions.

Also, here's a thought: would there be a need for the admin override if we allowed for simultaneous editing of master list records? If not, perhaps we should consider an option where we allow admin users to access the record at the same time. Given the task system we have in place, I'm wondering whether restricting access to a single admin user is necessary.

Thanks,

Morgan
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan ,

I will add this item to the agenda.

I wonder if these restrictions are in place to keeps things simple, in the sense that we only have one "master copy", and we do not have to worry about handling multiple versions and having to perform reconciliations between documents when ready to publish.

Harsh Parikh, Tech Lead at DevIT Harsh , from a technical and functional perspective, what are your thoughts on allowing multiple users to work on the same document in parallel?

Thanks,
--Martin
Martin Laporte, CTO at Tologix
We discussed the possibility of capturing the "Session.OnEnd" event in ASP.Net.
If we are able to do so, we could release/check-in any pending document under that user.

I have created DevOps item 1142 to research this.
Morgan Maguire, CEO
Perfect. Thanks Martin Laporte, CTO at Tologix Martin . I've approved item 1142 and put it in order 58.

Morgan 
Martin Laporte, CTO at Tologix
Hi Paul Moon Paul ,

We have a fix on Staging that will be able to capture when a user exits ISLG Admin by closing their tab or their entire browser. 

This should now prevent the original problem described by Morgan, where a document remains in editing mode when a user ungracefully exits ISLG.

Can you give this a test on Staging and report back here?

Thanks,
--Martin
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin :

Nafiseh Arghandehpour, Legal Content Manager at ISLG Nafiseh and I tested it on staging, and it seems to be working fine now.

Something slightly different that I notice these days is after Irit Weinfeld Irit uploads an HTML on app.islg, I get the same admin override message here and there when I go into a document to assign tasks. Is this something that should be posted separately?

Thanks,

Paul
Martin Laporte, CTO at Tologix
Hi Paul Moon Paul ,

Yes, let's post this issue separately. I have a feeling there might be a relation between the 2, but I think it will be easier to track it on its own.

Thanks,
--Martin
Paul Moon
Sounds good!
Paul Moon
Paul Moon completed this to-do.