TOLOGIX - ISLG App Rebuild

Location sorting function

Assigned to
Martin Laporte, CTO at Tologix Martin L.

Comments & Events

Paul Moon
Hi Martin Laporte, CTO at Tologix Martin :

As shown below, location sorting function is not working as expected for Analysis List. I expect to be able to sort it in descending paragraph order.

Please add to this sprint's unplanned/critical.

Thanks,

Paul
Martin Laporte, CTO at Tologix
Hi Harsh Parikh, Tech Lead at DevIT Harsh and Piyush Kanpariya, DevIT Piyush ,

I have added task https://dev.azure.com/tologix/ISLGRebuild/_workitems/edit/1500. I assume we will need to switch from the current alphanumeric sort to implement a custom sort which would:
  1. First, sort by prefix letters (alpha)
  2. Second, sort by suffix numbers (numeric)

Thanks,
-Martin

CC: Paul Moon Paul  

Paul Moon
Hi Harsh Parikh, Tech Lead at DevIT Harsh :

For IC/0237/12 that I recorded the video above, here is the order I want to see in SN entries.

pa93
pa93
pa94
pa95
pa97, pa98
pa98
pa98
pa106
pa111
pa111
pa118
pa120

Thanks,

Paul
Paul Moon
Hi Harsh Parikh, Tech Lead at DevIT Harsh and Piyush Kanpariya, DevIT Piyush :

I see DevOps 1500 is marked as done, and Sprint 13 items are deployed to app.islg as in 1556. However, IC/0237/12 SN entries are still not sorting the way that I expect it to.

Please update.

Thanks,

Paul
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin :

I linked to the correct item above (1556), but listed 1566 by mistake. I see 1500 is pushed forward to 1566 as you mentioned above. I'll wait for 1566 to be included in the next sprint.

Thanks,

Paul
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin and Harsh Parikh, Tech Lead at DevIT Harsh :

There is an improvement with the sorting algorithm. If it is a simple document (IC/0422/01 - until 00:39 of the first video), the logic works well, but as shown in the rest of the videos, there are two issues:

1. The second half of the video (from 00:40) shows when paragraph numbers have non-numbers (UN/0015/03), it is still sorting by lexical order.

-
-
paUN/0015/03/II/B, pa16
paUN/0015/03/II/B, pa19
-
-
paUN/0015/03/II/B, pa4
paUN/0015/03/II/B, pa9
-
-

It should be pa4, pa9,......pa16, pa 19 and so forth.

2. IC/0431/01 below shows even for simple documents, when there are different paragraph digits (pa647, pa 1009), the default is still lexical order instead of numerical order (pa 1009 still shows up first instead of pa 647).
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin and Harsh Parikh, Tech Lead at DevIT Harsh :

Please deploy the fix on Subject Navigator on staging.islg and test it, as this functionality request is most relevant for SN review (it is still useful for other tools).

Thanks,

Paul
Harsh Parikh, Tech Lead at DevIT
Hi Paul Moon Paul ,

We resolved location sorting issue on staging.islg only in AC tool. so please check first that tool and provide your feedback.

Once it is done from your side in AC tool then will do same things for others tools.

Cc : Martin Laporte, CTO at Tologix Martin  
Martin Laporte, CTO at Tologix
I tested sorting on Admin Staging against AC tool and found 2 issues:

  1. Pagination does not work. When clicking on the next page, the data is not refreshed.
  2. Roman numerals still need some adjustment (used UIN UN/0015/03):
Martin Laporte, CTO at Tologix
The 2 issues above have been addressed, and I did further testing today on Staging, using UINs that contain special cases (IC/0422/01, UN/0015/03 and IC/0431/01).

Per my testing, everything is sorted according to my expectations, and pagination works well.

I will mark this item as "Tested on Staging" in DevOps.

--Martin
Paul Moon
Thanks, Martin Laporte, CTO at Tologix Martin . Please deploy it to app.islg.

Paul
Paul Moon
Paul Moon completed this to-do.
Paul Moon
Paul Moon re-opened this to-do.
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin and Harsh Parikh, Tech Lead at DevIT Harsh :

DevOps 1566 indicates this fix has been installed on app.islg, but as shown below, it is still showing in lexical order (UN/0282/01 on app.islg showing "pa10, pa 8, pa9" instead of "pa8, pa9, pa10"). Could you look into it, and address this regression issue?

Thanks,

Paul
Martin Laporte, CTO at Tologix
Hi Paul Moon Paul ,

I will let Harsh Parikh, Tech Lead at DevIT Harsh chime in, but my understanding based on prior conversations was that we would not sort references within one entry, and instead, we would only take the first when performing the sort.

For example:
pa10, pa8, pa9
pa3
pa12, pa1

Would be treated as:
pa10
pa3
pa12

And final result would be:
pa3
pa10, pa8, pa9
pa12, pa1


Harsh Parikh, Tech Lead at DevIT Harsh : can you modify the new routine you build, so it also sorts each entry first? I think we would need to watch for performance degradation, but it might be worth a try.

Thanks,
-Martin
Martin Laporte, CTO at Tologix
Hi Paul Moon Paul ,

Harsh Parikh, Tech Lead at DevIT Harsh , Piyush Kanpariya, DevIT Piyush and I discussed this morning. 
Harsh will further research and provide a plan of action by tomorrow.

-Martin
Paul Moon
Looking forward to it, Martin Laporte, CTO at Tologix Martin .
Martin Laporte, CTO at Tologix
We discussed this morning, and Harsh Parikh, Tech Lead at DevIT Harsh and Piyush Kanpariya, DevIT Piyush believe they can have this resolved this week, hopefully on Staging by tomorrow. Stay tuned.
Paul Moon
Hi Martin Laporte, CTO at Tologix Martin :

Is there an update with this?

Thanks,

Paul
Martin Laporte, CTO at Tologix
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Were you able to complete this?

-Martin
Harsh Parikh, Tech Lead at DevIT
Hi Paul Moon Paul and Martin Laporte, CTO at Tologix Martin ,

This task is already completed and deployed on app.islg. I forgot to update in this thread.
Paul Moon
Thanks, Harsh Parikh, Tech Lead at DevIT Harsh .
Paul Moon
Paul Moon completed this to-do.