TOLOGIX - ISLG App Rebuild

No links to master list entries within ISLG Report

Assigned to
Harsh Parikh, Tech Lead at DevIT Harsh P. Melissa Cowell, General Manager at Industrial Melissa C. Naomi Joanis, UX Team Lead at Industrial Naomi J.
Notes
Further to the video below, reports generated through ISLG Reports do not contained links to applicable entries in the master lists. Please modify all reports so that any value listed in a report that is associated with a master list entry is linked to relevant page for the entry. The link should open in a new browser tab and bring the user to the following pages:

  1. Dispute: Dispute View (example: https://app.investorstatelawguide.com/DisputeDocuments/DisputeAllDetails?dis=cvCFaa91l3k%3D)
  2. Dispute Documents: Document View (example: https://app.investorstatelawguide.com/DocumentView?rt=Wk21nmb-fNY%3D&docid=B21Z88J4vRA%3D)
  3. Treaties: Document View (example: https://app.investorstatelawguide.com/DocumentView/TreatyRule?trid=C416u3APRCU=
  4. Arbitration Rules: Document View (example: https://app.investorstatelawguide.com/DocumentView?rt=Wk21nmb-fNY%3D&docid=B21Z88J4vRA%3D)
  5. People: Individual Reports page (example: https://app.investorstatelawguide.com/LegalAnalytics/ViewIndividualReports?mid=A8xoUq8Z0MM=&cmid=c%20ddpVXnRb8=&cat=FquW9SVOOfw=&rptype=5HDJ0zYs1oU=)
  6. Organizations: Individual Reports page (example: https://app.investorstatelawguide.com/LegalAnalytics/ViewIndividualReports?mid=mScOmwarSG4=&cmid=HmECNB0d1Bc=&cat=FOt2LfngpQk=&rptype=5HDJ0zYs1oU=
  7. Countries: Individual Reports page (example: https://app.investorstatelawguide.com/LegalAnalytics/ViewIndividualReports?mid=B5DG-lx3Ao8=&cmid=O-q2dQhQHt0=&cat=iqWQSglV1Qo=&rptype=5HDJ0zYs1oU=)
In addition, if there are multiple values within the same cell of the report, each value should have separate links.


Comments & Events

Morgan Maguire, CEO
In addition to the above, Melissa Cowell, General Manager at Industrial Melissa and Naomi Joanis, UX Team Lead at Industrial Naomi , could you confirm whether it is possible to create links for numbers of values when they are included in a report? For example, in the following report:  https://projects.invisionapp.com/share/JET7XMPSQFW#/screens/421830013 numbers are listed representing the number of instances the referenced person appears on the same dispute form as the reported person. My expectation is that selecting the number would connect to a different report listing the data relevant to the number of values. 

For example, if the user selected "2" under Counsel (Respondent) in the Penny Brown row, it would connect the user to a report showing the two cases where both "Penny Brown" and "Leslie Law" were both listed as Counsel (Respondent) within the Dispute form.

Thanks,

Morgan
Naomi Joanis, UX Team Lead at Industrial
Hi Morgan Maguire, CEO Morgan ,

In response to the video, your expectation is correct. As discussed in this thread: Re: Problems with links within Dispute and Dispute Document details - TOLOGIX - ISLG App Rebuild we were lacking more explicit criteria on the subscriber side to ensure consistent behaviour for countries, organizations, disputes and people when displayed and clicked on. So the question in the video should be addressed by the card linked in that thread. 

In response to your question above, because "numbers of values" are not fields in master lists we wouldn't be able to link these to a report. The report linking feature is intended to link values that are displayed throughout the application (for example when viewing dispute details) to a report. In this case, the mockup is not quite accurate, in the sense that the people's names would be the clickable values, but the numbers would not be. 

I hope that helps to clarify the report linking a bit further. 

Thanks, 

Naomi 
Morgan Maguire, CEO
Ok. Thanks Naomi Joanis, UX Team Lead at Industrial Naomi . Understood. I'll keep this to-do open so that we can track progress on linking people, organizations and disputes displayed in Dispute and Dispute Document details.

Thanks,

Morgan 
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan and Naomi Joanis, UX Team Lead at Industrial Naomi ,

Could you please specify more clarity that what is your expectation to clickable in Report and this link where we need to redirect ?
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ​,

Sure, I'll provide more detail today, but essentially, we want any master list entry (dispute, dispute document, treaty, arbitration rule, person, organization, country, etc.) listed as a value in any of the reports to be linked so that if the user selects the link in the report it will open a new browser tab and take the user to the relevant dispute/document view or individual report page.

Thanks,

Morgan
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

I've updated the requirements above with more details.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

In this task Could you please provide details that which Metafield is clickable and which are not ? how we will identify ?
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ​,

This links shouldn't be meta field specific, they should be dependent on the value type. If the meta field is displaying a value from any of the master lists above, the applicable link should be available. Make sense?

Thanks,

Morgan
Naomi Joanis, UX Team Lead at Industrial
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

These fields should link to the master list record:

"Case Name" – links to dispute all details page
"Full Citation" & "Short Title" – Link to dispute documents doc view
"Treaty Title" – Links to treaty doc view
"Arbitration rule name"  – Links to rule doc view
"Person name" – Links to person record landing page
"Organization name" – Links to org record landing page
"Country name" – Links to country record landing page

Thanks, 

Naomi 
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh and Naomi Joanis, UX Team Lead at Industrial Naomi ,

I think we should expand the list above to the following
  • Disputes
    • Case Name
    • Case Number
    • Short Title
    • Citation
    • UIN
  • Dispute Documents
    • UIN
    • Document Description
    • Short Title
    • Full Citation
  • Treaties
    • Title
    • UIN
  • Arbitration Rules
    • Title
    • UIN
  • People
    • Prefix
    • Given Name(s)
    • Surname(s)
    • Suffix
    • Full Name(s)
    • UIN
  • Organizations
    • Organization Name
    • UIN
  • Countries
    • Country Name
This will ensure that a link is produced no matter the field used to associate with the master list record within ISLG Reports.

Thanks,

Morgan
Piyush Kanpariya, DevIT
Hi Morgan Maguire, CEO Morgan ,

This issue is resolved on staging.islg. Please check and confirm.
Morgan Maguire, CEO
Hi Piyush Kanpariya, DevIT Piyush ,

Attached is video with another issue with sorting columns in ISLG reports on staging.islg:



Martin Laporte, CTO at Tologix Martin , could you confirm whether these releases are going through QA, because I assume these issues would have been caught by Sharmila Srikanth, Quality Assurance Engineer at Tologix Sharmila if they had.

Thanks,

Morgan 
Piyush Kanpariya, DevIT
Hi Morgan Maguire, CEO Morgan and Sharmila Srikanth, Quality Assurance Engineer at Tologix Sharmila ,

This issue is resolved on staging.islg. Please check and confirm.
Morgan Maguire, CEO
Hi Piyush Kanpariya, DevIT Piyush ,

The sorting function is working now; however, as described in the video below, the performance on staging.islg is very slow. It takes up to 45 seconds to load the following report: https://staging.investorstatelawguide.com/LegalAnalytics/SingleReports?cat=FquW9SVOOfw%3D&rptype=BT35dTu48nk%3D&rp=FOt2LfngpQk%3D&mid=A8xoUq8Z0MM%3D, which takes less than 10 seconds on app.islg. Also, selecting the columns to sort the results is not very responsive (takes up to 5 seconds for the columns to sort).

Thanks,

Morgan

Piyush Kanpariya, DevIT
Hi Morgan Maguire, CEO Morgan ,

The sorting issue is resolved on staging.islg. Please check and confirm.

For the performance issue, we will discuss tomorrow with Martin Laporte, CTO at Tologix Martin . Because the same SQL Query running in over local database with same amount of data within 10-12 second. But on carban60 server the query is taking 35-40 second.

We will let you know tommorrow after discussion with martin.

 
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan and Piyush Kanpariya, DevIT Piyush ,

I just tried the same report on Staging this morning, and my load time was 11 seconds, and sort clicks were instant.


--Martin
Morgan Maguire, CEO
Hi Martin Laporte, CTO at Tologix Martin ​,

Could you run a comparison between app.islg and staging.islg? My concern is that we may have compromised performance of ISLG Reports with these changes.

Morgan
Martin Laporte, CTO at Tologix
Hi Morgan Maguire, CEO Morgan ,

The same report on app.islg took 9 seconds, so between 1 and 2 seconds faster.
I believe this page loads all 7500 rows in memory. If it's the case, I think around 10 seconds load and render time is acceptable, though not optimal.


Piyush Kanpariya, DevIT Piyush : the debug log from Chrome had the following message:
jquery-3.3.1-jquery.min.js:2 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

Is there a way to enable async? This might help with performance.

--Martin
Harsh Parikh, Tech Lead at DevIT
Hi Martin Laporte, CTO at Tologix Martin ,

We checked and that is not issue. Actually, We need to make link for report column so we need to modified some logic in query and due to these dynamic reports building query it is taking 1 or 2 second more compare to app.islg.

Hope this is fine.
Martin Laporte, CTO at Tologix
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Thanks for the details. I did test against staging.islg 1 hour ago and it took 11 seconds to load for me, and the sorts were instant.

I wonder if the additional 20 seconds difference you experienced is related to network lag. Or perhaps it's a combination of network lag and performance limitations on our SQL or IIS server when there's more traffic.

The video capture of my staging.islg test can be found a few posts above.

Thanks,
--Martin
Harsh Parikh, Tech Lead at DevIT
Yes Martin Laporte, CTO at Tologix Martin .. You are right. The report is loading within 10 to 15 second. due to network traffic that time it was added extra seconds.
once we upgrade or seprate the database server then this issue will be resolved. 
Morgan Maguire, CEO
Ok. Things are running at an acceptable speed now. I guess it was a server related issue that I was experiencing yesterday. 

Marking the to-do complete.

Thanks,

Morgan
Morgan Maguire, CEO
Morgan Maguire completed this to-do.