TOLOGIX - ISLG App Rebuild

Problem with adding Peer branches to trees in both ILG and ISLG

Assigned to
Melissa Cowell, General Manager at Industrial Melissa C. Naomi Joanis, UX Team Lead at Industrial Naomi J.
Notes
Further to the video below, there is an issue concerning how Peers are added to trees in both ILG and ISLG. In both applications, when a peer is added to the tree, rather than adding the peer directly below the branch originally selected (as it does in the current ISLG application), the new branch gets added to tree alphabetically. I can see the utility in maintain the alphabetical addition for adding child branches, but the admin user probably wants to add the branch to specific location when they add a peer.


Comments & Events

Melissa Cowell, General Manager at Industrial
Morgan Maguire, CEO Morgan  

This is an issue we discussed previously with DevIT for ISLG. You can see the discussion here:
https://industrialagency.tpondemand.com/entity/13649-add-new-subject-greater-add-to

For ISLG we agreed based on technical implications that branches will be added to the top of the level. However, this is hopefully acceptable given that branches can be reordered. 

I have added the card for ILG in Target Process here as I'm not sure whether the implementation is the same or not:

ILG: https://industrialagency.tpondemand.com/entity/16398-ilg-team-feedback-add-peer-greater

Mel
Morgan Maguire, CEO
Hi Melissa Cowell, General Manager at Industrial Melissa ,

I'm not sure what happened on the implementation, but the behaviour for adding peer and child branches should match the behaviour in the existing ISLG application. This is what I requested in my comment here:



Thanks,

Morgan
Morgan Maguire, CEO
Hi Melissa Cowell, General Manager at Industrial Melissa ,

We didn't have a chance to discuss this this morning, but if further clarification is needed, please let me know, and we can have a quick call to discuss.

Thanks,

Morgan
Melissa Cowell, General Manager at Industrial
Morgan Maguire, CEO Morgan

If you notice the last comment in thread from Harsh:

"As discussed on Monday call (10/02/2020), Due to technical reason, all added new branch will display at top."

I'll need Harsh Parikh, Tech Lead at DevIT Harsh to comment on the significance of the issue. 

Mel
Melissa Cowell, General Manager at Industrial
Morgan Maguire, CEO Morgan  

Circling back to this. Based on my discussions with the dev teams for both ISLG and ILG it is not possible to implement both ordering/reordering functions. 

In ISLG, since we have drag and drop reordering we cannot also implement specific ordering when adding a peer branch because the logic will conflict. Therefor, new branches will always be added to the top of the relevant level.  

In ILG, since we will be implementing specific ordering when moving or adding a branch (peer above, peer below, child), drag and drop reordering will not be possible. 

I don't fully understand the technical implications but I have been assured that it must be either one or the other. 

Mel
Morgan Maguire, CEO
OK. Thanks Melissa Cowell, General Manager at Industrial Melissa .

For ISLG, this is a pretty significant limitation . It's going to get very messy in the Subject Navigator if we can't insert new branches within specific locations, particularly when we add all new entries to the bottom of the level within the existing application.

Harsh Parikh, Tech Lead at DevIT Harsh , is there a way to at least have every new branch added to the bottom of the level, rather than the top? At least this would avoid the problem or reordering every single new entry added to tree.

For ILG, does this mean we could easily switch to the ISLG reordering system or would that be a significant job?

Thanks,

Morgan
Melissa Cowell, General Manager at Industrial
Morgan Maguire, CEO Morgan  for ILG, Jitesh indicated that it would be significant to implement the reorder function (approximately 2 weeks) and so when you and I discussed it previously we decided to instead implement the more precise add/move function.  
Morgan Maguire, CEO
OK Melissa Cowell, General Manager at Industrial Melissa . Thanks. We'll keep the current requirements within ILG then (with the modifications requested in the user stories here: Re: Problem with moving topics within tag directory - TOLOGIX - Infrastructure LawGuide (ILG).

However, we need to address the outstanding issues with ISLG. I'm going to add this to agenda for Thursday's call, but Harsh Parikh, Tech Lead at DevIT Harsh , following up on my question above would it be possible to implement a change that would allow new branches to be added to the bottom of the level, rather than the top? We can probably live with not being able to insert Peer branches directly below the selected branch, but it's very important that we add new branches to the bottom of the level to keep it consistent with the taxonomy within the existing application.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Yes Morgan Maguire, CEO Morgan ​..It is possible but we will discuss more on thurshday call and then will decide.
Morgan Maguire, CEO
Ok. Sounds good, Harsh Parikh, Tech Lead at DevIT Harsh . We'll discuss then.

Morgan
Melissa Cowell, General Manager at Industrial
Morgan Maguire, CEO Morgan  

I'd just like to confirm that you had previously decided that adding to the top of a level would be easier for admins to manage. As I recall our discussion, the thought process was that adding branches to the top of the level would make them easier for admins to find/access via the reorder function. 

Either way will work but I want to certain you are considering that this was an intentional decision based on the previous discussion. 
 

For reference: https://industrialagency.tpondemand.com/entity/13649-add-new-subject-greater-add-to
Morgan Maguire, CEO
Hi Melissa Cowell, General Manager at Industrial Melissa ,

The discussion in the TargetProcess referenced above was made in the context of having the ability to insert peer branches below the branch where they were inserted. The decision to add branches to the top of the level was only made for in the context of where a child branch was added, not a peer branch. This way the admin user would be be able to add branches to the top of the next level or below a specific branch depending on whether they decided to add a peer or child branch. However, now that we've eliminated the ability to add branches below the peer, we need re-examine the whole process.

I'm going to discuss with Paul Moon Paul and we'll discuss on Thursday.

Thanks,

Morgan
Morgan Maguire, CEO
Hi Melissa Cowell, General Manager at Industrial Melissa and Harsh Parikh, Tech Lead at DevIT Harsh ,

I had a discussion with Paul Moon Paul on the issue above, and I'd like to outline our proposed options for resolving the problem in order of preference:
  1. All options available in existing application:
    • Adding peer = new branch is added directly below the branch where it is added.
    • Adding child = new branch is added to the top of the next level below where the branch is added.
  2. Different results for peer and child branches:
    • Adding peer = new branch is added to the bottom of the same level where the branch is added.
    • Adding child = new branch is added to the top of the next level below where the branch is added.
  3. Always add branch to bottom of level:
    • Adding peer = new branch is added to the bottom of the same level where the branch is added.
    • Adding child = new branch is added to the bottom of the next level below where the branch is added.
Harsh Parikh, Tech Lead at DevIT Harsh and Ketan Sondarva, Technical Project Manager at DevIT Ketan , please review and determine the amount of time needed to achieve each of these options, and we will determine the appropriate solution during our call on Thursday.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ​,

Do you want to implement any one from above mentioned 3 proposed solution in ISlG?
Morgan Maguire, CEO
Hi Harsh Parikh, Tech Lead at DevIT Harsh ,

Yes, we want to implement 1 of the 3 options above in order of preference (i.e., option 1 is the most preferred and option 3 is the least preferred). Could you please estimate the amount of time to implement all three options, and we'll do a cost-benefit analysis to determine which option to implement.

Thanks,

Morgan
Morgan Maguire, CEO
Hi Naomi Joanis, UX Team Lead at Industrial Naomi and Melissa Cowell, General Manager at Industrial Melissa ,

During our call on July 23rd, we agreed that implementing option 1 above is feasible. Could you please confirm whether the appropriate requirements have been integrated into the applicable user stories.

Thanks,

Morgan
Harsh Parikh, Tech Lead at DevIT
Hi Morgan Maguire, CEO Morgan ,

This task is completed on rebuilddemo.islg. Please complete this task.
Morgan Maguire, CEO
Morgan Maguire completed this to-do.