Hi Morgan ,

We have increased the Research Topic limit up to 100 on www.islg.

Hi Harsh

I'm testing on www.islg with my account ISLGtesting / ISLG4testing and saved research "Test 100." When going back in, opening that saved notepad, then adding new topics to it, it's taking a couple minutes to add the new topic to the list. Morgan I'd be interested to see if you're experiencing the same, or if it's just my connection.

Thanks!

Ryan

Things are working fine on my end. The credentials ISLGtesting / ISLG4testing don't seem to be working for me on www.islg. Ryan do you mind running the test again to ensure this is still an issue. However, I did notice that once you've a 10+ topics it take longer to load the Research Topic window. Harsh , this is the performance issue I was worrying about. It should never take more than 1-2 seconds to load this page. Is there a way for us to speed this up?

Thanks,

Morgan

Shoot, sorry guys. The password for that account is "islg4testing". I'm still seeing long load times as well.

Ryan

No problem Ryan . I've been able to recreated the problem. Looks like it's similar to what I've pointed out above. Here is a video showing the issue:

Problem with loading research topic window (2-Apr-19).mp4 3.37 MB • Download

Harsh , please ensure we can get the loading times reduced to 1-2 seconds. We have to ensure that system can accommodate research topic windows that may have up to 1000 bookmarks added to research topics without there to be affect on loading times.    

Hi Morgan and Ryan ,

We have changed logic which render the Research Topic data on popup and also optimize the Research Topic data fetch query and uploaded on dev.islg.

Ryan , Could you please test your yesterday's case on dev.islg and let us know the feedback.

Hi Morgan and Ryan ,

I have uploaded above changes on www.islg for testing purpose. 
We have checked above scenario using Ryan's credentials and found that Research Topic Popup is opened within 1 to 2 seconds. 

But if we having 100 of records under Research Topic then it is taking near about 1 minute to load all 100 record. For other Research Topic it will take 1 to 2 seconds.

Is it possible that any user will save 100 of records under one Research Topic ?

Hi Harsh ,

The loading time from the Research Topic window looks a lot better to me. Ryan , let us know if you see the same.

Harsh , unfortunately, if used properly it is no inconceivable for a user to add 100 bookmark to a particular topic. Is there a ways for us to optimise this to load quickly, and then perhaps put a limit of 100 bookmarks per topic?

Thanks,

Morgan    

Hi Harsh and Morgan  

It does seem faster for me with my large test notepad, but on first load can still take 20-30 seconds.

I'm not sure if it's just my test account, but the export DOC isn't showing any bookmarks in it. See attached.

ResearchTopicDetailReport (14).doc 29 KB • Download

Hi Morgan and Ryan ,

The export DOC is working now on both dev.islg and www.islg.

For Loading 100 of bookmark records, I suggest that If we will use lazy loading functionality for bookmarks records then it will be loaded on demand when user scroll down. 

(For ex. We will be fetched 20 records on each scroll down and If bookmark records are less than 20 than scroll will be hidden).

Please suggest.

Hi Harsh ,

The lazy load sounds fine to me. However, how would this function if the research topic is loaded into the Research Details window. Would there be slow down there as well?

Morgan

Hi Morgan ​,

We don't need lazy load for Research Topic Title data. we will set lazy load for bookmark data under Research Topic title. it mean when you expand any research topic title and if bookmark record more than 20 then bookmark record will be loaded using lazy loading.

For an example, Ryan has save 100 bookmarks under Research Topic Title. so we will develope lazy load for those 100 records.

Hope this is fine.

Ok. That's fine Harsh . Let's make the changes on dev.islg, and see how it work.

At the same time, I wasn't referring to the research topic titles. I was referring to when the user opens the topic in the Research Details window (see screenshots below). What effect would 100 bookmark links have on this aspect of the application? Would there be significant load times? If so, should we introduce the lazy load feature here as well?

Also, what effect will the lazy load feature have on changing the order of bookmarks through drag/drop?

image.png 139 KB • Download

image.png 181 KB • Download

Thanks,

Morgan

Thanks Harsh . The exports look good to me on dev.islg & www.islg.

Ryan

Hi Morgan and Ryan ,

There will be no any effected on drag/drop functionality. It is working as it is.

We have developed lazy load for bookmark records and uploaded on dev.islg. Please check and let us know the feedback.

Hi Harsh  

I've run some tests and I'm not seeing a large improvement in load time. In my test account, I'm still seeing initial loading times of my "Test 100" research details taking up to 30 seconds.

Ryan

I'm getting similar results. Further to the videos below, the lazy load is very clunky and needs to cleaned up so that bookmarks load continuously without any delay. Also, the second video shows significant loading times when opening the bookmarks in the Research Details window.

Problems with lazy load in Research Topic window (5-Apr-19).mp4 2.69 MB • Download

Problems with loading time in Research Details window (5-Apr-19).mp4 1.8 MB • Download

 

Hi Morgan and Ryan ,

We are looking in to it and try to improve the performance. Actually, The Encryption/Decryption algorithm is taking some time to decryption each record one by one and fill up in popup.

We will update you soon.

Ok. Thanks Harsh .

Note I don't want to spend an inordinate amount of time on this issue, but I assume this work will help inform us on how to resolve these issue in the rebuilt environment? 

Morgan 

Hi Morgan ,

We are making Rebuild with new technology and well manner database structure and project architecture. so, we are keeping this thing in mind that we will not face any performance issue in ISLG Rebuild.

For existing application we need to change whole function of loading Research Topic Bookmarks and it will take some time. 

Can we start to change whole loading method of Research Topic Detail ?

Please suggest.

Hi Harsh ,

Before we proceed, I have two queries:

Thanks,

Morgan

Hi Morgan ,

       -  One Resource with 3 to 4 days (considered both Research Detail                       window and bookmarks under research topic title).

   2.    Can we run a query to determine the highest number of bookmarks                  that have been added to a research topic by active users on www.islg              (excluding any accounts used for testing or associated with the Tologix            or Investor-State LawGuide groups)? This will help us determine if this               a  material issues to current users, and whether we need to spend the               resources at this point to fix it, or leave it for the new platform.

      -  We have run query on www.islg  database and found that highest 97                 bookmarks have been added in one research topic by active users.

           Following, I have attached report of bookmark count of all active users            with column Subscriber Name, Research Topic Tile and
          bookmark count.
          Please take note that Research Topic Tile is in encrypted format.

Bookmark Count Report.xlsx 14.5 KB • Download

 

           

Hi Harsh ,

Ok. If users are adding that many bookmarks, we better resolve the problem. Please go ahead and implement the fix.

Thanks,

Morgan 

Hi Morgan ,

We are working on it. we tried different method like lazy loading, paging but we didn't get as much performance which we need.

The reason is Decryption of all bookmarks record one by one. Now, we are going to try encrypt & decrypt all bookmark records through SQL query.

We will keep you updated.

Ok. Thanks for the update Harsh . Keep working through, and hopefully this will inform how we need to build things for the new application as well.

Morgan 

Hi Morgan   and Ryan ,

We have done Encryption / Decryption through SQL and changed the loading bookmarks data in both Research Window and Popup on dev.islg

Now, The performance of loading bookmarks has been massively improved. Please check and let us know the feedback.

Please take a note that we have also updated already existing bookmarks data through SQL encryption method on dev.islg

Hi Harsh ,

Wow. It's a huge improvement in loading times. It doesn't look like we even need the lazy loading feature any more.

Ryan , let us know your thoughts, and assuming you don't find any issues, we'll get this migrated through next week.

Also, just confirm the settings on the current configuration, Harsh are we imposing any limits on the number of topics and bookmarks? Just to be safe, perhaps we should impose a limit of 100 topics and 100 bookmarks within each topic.

Morgan

I spoke too soon.

Harsh , further to the video below, I discovered a problem with the links contained in the Research Reports:

Problem with Research Report links (18-Apr-19).mp4 2.45 MB • Download

We'll need to ensure this gets resolved before we migrate anything through to www.islg.

Morgan

Hi Harsh  

I've found a few bugs to look into please:

Thanks!

Ryan

Morgan   , The issue which you raised above has been resolved on dev.islg.

Ryan , We have resolved 2nd and 3rd issue on dev.islg but we haven't found any issue in Research Window scrolling while added bookmark. Please check once again and let me know

Morgan  , Could you also please check the  unable scrolling issue (Ryan's First issue) at your end ?

Hi Morgan ,

We need to impose a limit up to 200 topics and 200 bookmarks within each topic.

I think performance will be remain same up to 200 records.

Hi Harsh ,

I'm currently out of the office. I'll test the fixes on Monday. 

However, just to confirm, the system will be able to handle 200 topics at 200 bookmarks per topic (i.e., a maximum of 40,000 bookmarks)?

Thanks,

Morgan

Hi Harsh ,

Everything is working well for me. Ryan , could you please test to confirm.

Also, Harsh , please confirm that the new limits of 200 topics at 200 bookmarks per topic will not cause performance issues.
 
Thanks,

Morgan 

Hi Harsh . Here are my testing results.

Hi Ryan ,

I'm note sure if #2 above is in the existing requirements, but it makes sense to add it. Harsh , please integrate these changes.
 
Morgan 

Hi Morgan   and Ryan ,

For #2 issue, We can not directly "un-bookmark" the link by clicking on blue bookmark icon. We can remove the bookmark link from Research Window using Delete button. When you delete the bookmark from Research Window then it will be automatically "un-bookmark" (i.e  Remove the blue icon from page).

bookmark-delete.png 195 KB • Download

Morgan , If we are going to Integrate this change then we need to modify whole logic of bookmarking (blue icon) because we need to also remove the link from database. It will take some time to integrate this change in all pages. 

Please suggest.
 

Hi Ryan ,

The issue #3  Re-adding deleted bookmark issue has resolved on dev.islg.

For Scrolling issue (#1), Still I am not able to reproduce the issue from my end. Could you please tell us which OS and browser you tested ?

Morgan , Are you able to reproduce the Scrolling issue ?

Hi Harsh ​,

For issues #2, I don't want to spend anymore time on this issue. We'll leave things as is where the user needs to delete the bookmark from the Research Details.

Thanks,

Morgan

Hi Harsh and Morgan  

I've run testing and confirmed #3 is resolved. For the scrolling issue, I'm seeing it on Chrome/Mac and Firefox/Mac. I don't see the issue when testing on Windows from my end.

Thanks!

Ryan

I forgot to mention, my bookmark contained just over 260 items and it loaded extremely quickly in all browsers. Great job!

Hi Harsh and Ryan ,

I'm not able to reproduce issue #1, it's scrolling as expected. Could this be a Mac issue?

Also, Harsh , please confirm that the new limits are 200 research topics and 200 bookmarks per topic (i.e., 40,000 bookmark max - 200 x 200), and that this will not cause performance issues.  

Thanks,

Morgan

Ryan ,Still We are not able to reproduce the scroll issue in Mac Chrome & Fire Fox. It is working fine in both Mac and Windows.

Morgan , Could you please check the scroll issue in Mac at your end ?

Hi Ryan and Harsh ,

I don't have access to a Mac, so I can't provide any testing feedback.

Ryan , can you run another test to confirm the issue is still present? Also, perhaps you could provide more details on the environment used so that Harsh can reproduce the issue (version of operating system, browser, etc.)

Thanks,

Morgan

Hi Harsh and Morgan  

It doesn't seem to be happening anymore if I wait for a second to scroll, rather than moving the cursor immediately into the Notepad window and attempting to scroll. It's not happening every time, so I don't think we should spend anymore time on it.

Thanks!

Ryan

Ok. Sounds good. Thanks Ryan .

Harsh , could you please confirm research topic and bookmarks limits (200 research topics and 200 bookmarks per topic - 40,000 bookmark max - 200 x 200). Once you confirm that these limits will not cause performance problems, we're ready to migrate the changes to www.islg.

Thanks,

Morgan 

Hi Morgan ,

It will not cause any performance issue but the loading time might be increase some level (near about 1 minute) because system will be going to fetch 40,000 record. I think this will be OK and we should migrate this task on www.islg.

Let me know when we migrate this task on www.islg.

Hi Harsh ,

1 minute loading times are not acceptable. Please lower the limit to 100 topics and 100 bookmarks per topic.

Thanks,

Morgan

OK Morgan .

When we will merge to www.islg ?

One more thing we can do. We will set research topic limit up to 100 but user can save bookmark details up to 200 within particular research topic.

This thing will take approx near about 30 to 35 seconds to load. 

Please Suggest

Let's keep it to 100 topics and 100 bookmarks. We should avoid any functions that creates loading times beyond 5-10 seconds.

OK Morgan .

Great. Thanks Harsh ​. Assuming the new limit is in place, let's proceed with the migration to www.islg.

Hi Morgan ,

We have set the limit up to 100 in our local environment and tested it for both Research Topic and Bookmarks.  

Tomorrow, We will migrate this change on www.islg (Ahmadabad Morning time 10 AM). Because We need to pull down live site for half n hour to update old research topic and bookmark data through SQL encryption/decryption method.

We will also set the offline page during that time.

Hope this is Fine.

Ok. Sounds good Harsh . However, if the whole site is going down we'll need to provide users with more notice. Let's schedule this for Friday, May 3rd at 10am Ahmedabad time. 

Also, what will users see if they navigator to the site during the down time? We need to ensure the notice is something informative. Could you please provide a sample?

Thanks,

Morgan

Hi Morgan ,

Following, Attached html file will be run while any user navigator to the site during down time.

App_Offline.htm 1.39 KB • Download

 

Ok. Great. Thanks Harsh . Could we insert the ISLG logo below into the page as well. Please insert logo at the top of page (centre alignment) with linebreaks before top of page and between logo and body text.

Thanks,

Morgan

ISLG-FullHor.png 46.3 KB • Download

Hi Morgan and Ryan ,

We have migrated this task on www.islg and all are working fine. We have also encrypted the already exists Notepad data using SQL Encryption Method.

Please check and let us know the feedback.
 

Great. Thanks Harsh .

Ryan , could you please test the system to make sure everything is running as expected. I have some appointments this morning, and won't be able to test until later this morning.

Thanks,

Morgan

Looking at this now. Thanks all.

Ryan

Hi Morgan and Harsh  

I've done some testing on www.islg and it seems to be working very well, but I did notice an issue with bookmarking Dispute Document results. This could be an existing issue, but I'll log it here in case it's a regression.

I'm seemingly only able to bookmark one set of results. See attached video where I perform one search, bookmark it, then perform a second search, and the results for the second one are already bookmarked.

screencast 2019-05-03 10-44-37.mp4 60.7 MB • Download

Hi Ryan ,

I'm seeing the same problem. This definitely has to be resolved. I'm wondering if this has to to with the fact that the bookmark description doesn't include any details on what was included in the documents directory (e.g., term searched in the search field, filters applied, etc.). I'm fairly certain this resolved in previous versions.

Harsh , please ensure this is resolved.
 
Thanks,

Morgan 

Hi Morgan   and Ryan ,

We are working on this issue and tomorrow we will be uploaded on dev.islg.

Hi Morgan and Ryan ,

Above Dispute Document bookmark issue has resolved on dev.islg. Please check and let us know the feedback.

Note : Please clear your cache and refresh the Dispute Page before test this functionality.

Morgan, If you need to change the format of bookmark description then Please tell us.

Looking good, thanks Harsh .

Morgan, we may want to take a look at how we separate the filters within the bookmark, specifically when there are a lot. See screenshot of some searches I've bookmarked on dev.islg where I've selected several different filters. We're using "|" and commas to separate, but it's not entirely obvious in some cases.

Screen Shot 2019-05-07 at 11.44.07 AM.png 254 KB • Download

Hi Ryan and Harsh ,

We dealt with this a long time ago when we originally built the tool in 2014. The following document, provides requirements on what should be included in bookmark descriptions:

ISLG Notepad Feature Requirements - Phase 2 - Part 2-2.doc 24.8 MB • Download

Section 4(a) deals specifically with bookmark descriptions under the Dispute Documents tab. Harsh , please review, and let us know if you need any additional information on how to modify the bookmark descriptions.

Thanks,

Morgan

Hi Morgan and Ryan ,

We have updated the Dispute Document bookmark description as per attached word file and uploaded on dev.islg.

Please take a note that If user selects multiple check-boxes in filter then we separated the value with "-".  Because There is no description available in word document if multiple check-boxes selected in Dispute Document Tab.

For Ex. If user selects English & Spanish language then bookmark description will be displayed English-Spanish. 

Hi Harsh ,

Let's used " + " to indicate more than one filter selection from the same type (e.g. English + Spanish), and " | " to indicate additional filter types (e.g., English + Spanish | Albania - Greece BIT (1991) + Argentine - United States BIT (1991)).

Using hyphens doesn't work, because they are found in the text for the labels of treaties and arbitration rules.

Thanks,

Morgan

Hi Morgan and Ryan ,

As per above comment of Morgan, We have changed the bookmark description format of Dispute Document set and uploaded on dev.islg.

Please check and confirm.

Hi Harsh  

I've found some formatting issues and a functional issue. See below:

I've saved my research under "Dispute Doc testing - 0509" with my user account ISLGtesting/islg4testing if you'd like to reproduce this.

Thanks!

Ryan

Hi Ryan ,

Above all issues have been resolved and uploaded on dev.islg.

Please remove all your existing bookmarks under "Dispute Doc testing - 0509" and check again.

Thank you, Harsh . This is looking good to me on dev.islg.

Ryan

Looks good Harsh , but I noticed an instance where an extra "+" was added in the filter description: http://dev.investorstatelawguide.com/disputedirectory/DisputeDocument?hidAccordionIndex=&toc=disputedirectory&cat=&mainfilter=4,5,7&ID=10&treatycat=&DocumentLanguage=E,S&aprule=icsidarbrule1968,icsidaddfac1978,icsidarbrule1984,icsidaddfac2003,icsidarbrule2003,icsidaddfac2006,icsidarbrule2006&index=&refresh=1&search=ICSID&treaty_id=62&disp_treaty=%27Argentina%20-%20United%20States%20BIT%20(1991)%20and%20Protocol%27,%27NAFTA%20-%20Chapter%2011:%20Investment%27,%27Argentina%20-%20France%20BIT%20(1991)%20[English%20translation]%27,&treaty_id1=Argentina%20-%20United%20States%20BIT%20(1991)%20and%20Protocol&treaty_id2=NAFTA%20-%20Chapter%2011:%20Investment&treaty_id3=Argentina%20-%20France%20BIT%20(1991)%20[English%20translation]&defendingCountrydisp=50&dispState=%27Argentina%27,%27Mexico%27,&dispCountry1=Argentina&dispCountry1=Mexico&aprule_icsid_addfac_1978=1&aprule_icsid_arbrule_2003=1&aprule_icsid_addfac_2003=1&aprule_icsid_arbrule_2006=1&aprule_icsid_addfac_2006=1&aprule_icsid_arbrule_1968=1&aprule_icsid_arbrule_1984=1&DocLanguage_English=1&DocLanguage_Spanish=1&doccat_5=1&doccat_4=1&doccat_7=1#directory

image.png 384 KB • Download

 

Hi Morgan ,

The "++" issue has bee nresolved on dev.islg. Please check and confirm.

Looks good on dev.islg. Thanks Harsh !

Looks good Harsh . Scheduling this for migration tomorrow.

Morgan 

Hi Morgan and Ryan ,

We have migrated this task on www.islg. Please check and confirm. Please clear your cache or refresh the page properly to load all JS files.

Hi Harsh ,

Things looks good to me. Ryan , if you confirm, you can mark this to-do complete.

Morgan

Looks good to me as well Harsh Morgan  

Thanks!

Ryan

OK. Great. Marking to-do complete.

Morgan