Basecamp Export

From the list: Regression/Maintenance Issues - Maintenance

✔ Problem with loading XML documents

Morgan M. added this on Jul 03, 2019
Completed Jul 12, 2019 by Paul M.

Assigned to: Harsh P. Jitesh D.
Due on: Jul 10, 2019
Notes: Further to the video below, we have discovered a problem with the XML document uploader in XML Agreements: https://www.investorstatelawguide.com/CoreComponents/AddAgreement

The XML document uploader should be able to handle any type of latin character, including the characters we're having issues with in BIT/1158: https://www.investorstatelawguide.com/CoreComponents/Agreements_BitsEdit?toc=editXml&agreementID=1799. Could you please confirm that the uploader is able to handle all UTF-8 latin characters: https://www.utf8-chartable.de/unicode-utf8-table.pl

Here is the XML document from the video that failed to upload correctly:

BIT-1158 - Bulgaria-Finland BIT (1997)[Finnish].xml 18.9 KB • Download

Problem with XML document uploader (7-Jul-19).mp4 12.3 MB • Download

Comments & Events

Harsh Parikh, Tech Lead

Morgan

and

Ryan

,

We have resolved above loading XML issue on dev.islg. Please check and let us know the feedback.

If you have already uploaded above XML file on dev.islg then first remove it and then again upload it.

Jul 04, 2019 at 10:06 AM Notified 7 people

Paul Moon

Harsh

:

I tried to check it on dev.islg, but Treaties & Rules gives me the following error message, so I cannot check whether the problem has been resolved or not. I have tested on Chrome and Edge.

https://dev.investorstatelawguide.com/Treaties/Index?toc=mainAnnot&cat=&tab=

image.png 165 KB • Download

Is there something wrong with Treaties & Rules? Please let me know.

Thanks,

Paul

Jul 04, 2019 at 4:24 PM Notified 7 people

Harsh Parikh, Tech Lead

Paul

,

The error in Treaties & Rules is resolved on dev.islg. Please check and let us know the feedback.

Jul 08, 2019 at 9:53 AM Notified 7 people

Ryan Knuth, Customer Support Manager

Harsh

They are loading for me on dev.islg.

Paul

Please try http://dev.investorstatelawguide.com/Treaties/Index?toc=mainAnnot&cat=&tab= (without the "s" on https in the URL).

Thanks!

Ryan

Jul 08, 2019 at 1:16 PM Notified 7 people

Paul Moon

Harsh

and

Ryan

:

Yes, it is working for me now. Is the foreign character issue resolved as well on dev.islg? Since these are new XMLs that were uploaded in the last few weeks, you may have to sync content on the dev site for us to check.

Thanks,

Paul

Jul 08, 2019 at 5:26 PM Notified 7 people

Morgan Maguire, CEO

Paul

,

This issue concerns the XML uploading process. To properly test the system, you'll need to upload the problem XML documents through XML Agreements to determine whether the foreign characters are properly generated in the XML code. Could you please run these tests by uploading the relevant agreements, and report back the results.

Thanks,

Morgan

Jul 08, 2019 at 5:52 PM Notified 7 people

Paul Moon

Morgan

:

Understood.

Irit

will test all XMLs that we had issues with recently and report back here.

Thanks,

Paul

Jul 08, 2019 at 6:07 PM Notified 7 people

Morgan Maguire, CEO

Great. Thanks

Paul

and

Irit

, please note that you are testing the XML uploader under XML Agreement on dev.islg.

Morgan

Jul 08, 2019 at 6:09 PM Notified 7 people

Irit Weinfeld

Hi Morgan and Paul,

The following have been uploaded to dev.islg:

BIT/1158

http://dev.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1534&tabcontent=&cat=bit

BIT/1159

http://dev.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1535&tabcontent=&cat=bit

BIT/0081 The indentation problem in Article II still appears:

http://dev.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=267&tabcontent=&cat=bit

Thanks,
Irit

Jul 08, 2019 at 6:51 PM Notified 7 people

Paul Moon

Thanks,

Irit

Morgan

: BIT/0081 is a different issue as I mentioned before (indentation, not foreign character). Should BIT/0081 be posted separately or dealt with here?

Paul

Jul 08, 2019 at 7:07 PM Notified 7 people

Morgan Maguire, CEO

Irit

and

Paul

,

We're focusing on the character issue for this to-do. Please post any indentation issues in a separate to-do. However, perhaps you should explain them to me in-person first. Please focus on the non-English character issue. It appears to be resolved, correct?

Morgan

Jul 08, 2019 at 7:19 PM Notified 7 people

Paul Moon

Morgan

:

Yes, we can upload XMLs with foreign characters without an issue on dev.islg now.

Thanks,

Paul

Jul 08, 2019 at 7:36 PM Notified 7 people

Morgan Maguire, CEO

Ok. Great. Thanks

Paul

Harsh

, I'll schedule this to-do for migration to www.islg tomorrow.

Paul

and

Irit

, please note that any documents where this issue is occurring will need to be replaced in XML Agreements after the fix is implemented. I suggest doing an audit any documents in similar languages.

Thanks,

Morgan

Jul 08, 2019 at 8:22 PM Notified 7 people

Paul Moon

Hi Irit:

I know we made most of these documents inactive, but let’s ensure you replace them after the migration.

Thanks,

Paul

Jul 08, 2019 at 8:28 PM Notified 7 people

Morgan Maguire, CEO

Irit

and

Paul

,

Note that replacing the applicable XML documents will require deleting the old versions from XML Agreements, uploading fresh version through the XML uploader, and re-associating any of the new XML documents with the applicable documents in the PDF document database.

Morgan

Jul 08, 2019 at 9:05 PM Notified 7 people

Harsh Parikh, Tech Lead

Morgan

,

Let me know when we migrate this change on www.islg ?

Jul 09, 2019 at 8:01 AM Notified 7 people

Irit Weinfeld

Hi Morgan, can I go ahead and replace the XML documents for BIT/1158 and BIT/1159?

Jul 09, 2019 at 2:10 PM Notified 7 people

Morgan Maguire, CEO

Irit

,

No, not yet. It looks like we didn't migrate the changes through to www.islg.

Harsh

, I'll schedule for migration to www.islg tomorrow.

Thanks,

Morgan

Jul 09, 2019 at 2:19 PM Notified 7 people

Morgan Maguire rescheduled this to-do

Was Jul 09, 2019

Now Jul 10, 2019

Jul 09, 2019 at 2:20 PM Notified 2 people

Morgan Maguire, CEO

Harsh

, I'm a little confused. I received a message saying you migrated the changes to www.islg, but I don't see it above now. Were the changes migrated through to www.islg yet?

Morgan

Jul 09, 2019 at 2:34 PM Notified 7 people

Harsh Parikh, Tech Lead

Morgan

. I was going to migrated but suddenly the protocol came to my mind and then I didn't integrated changes on www.islg.

Jul 09, 2019 at 3:30 PM Notified 7 people

Morgan Maguire, CEO

OK. Sounds good

Harsh

. Let's migrate things through tomorrow. Note that I've discovered an additional outlined in this to-do: Problem with <linknum> tags in XML Agreements - TOLOGIX - ISLG Maintenance, but we'll deal with this separately.

Morgan

Jul 09, 2019 at 6:44 PM Notified 7 people

Harsh Parikh, Tech Lead

Morgan

Ryan

Irit

and

Paul

,

We have migrated this task on www.islg. Please check and confirm.

Please take a note that deleted the Old existing foreign characters XML file and again upload the new XML through the XML uploader.

Jul 10, 2019 at 9:55 AM Notified 7 people

Irit Weinfeld

Good morning everyone,
The following XMLs were deleted from the XML Agreements, then uploaded as though they were new (on the XML uploader). They have all been re-associated with the applicable document in the PDF document database. Below are links to the live site:
BIT/1158

https://www.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1812&tabcontent=&cat=bit

BIT/1159

https://www.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1813&tabcontent=&cat=bit

BIT/1163

https://www.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1814&tabcontent=&cat=bit

BIT/1164

https://www.investorstatelawguide.com/Treaties/AnnotDocument?toc=annotSection&agreementID=1815&tabcontent=&cat=bit

Thanks,
Irit

Jul 10, 2019 at 2:44 PM Notified 7 people

Morgan Maguire, CEO

Ok. Great. Thanks

Harsh

and

Irit

Paul

, if everything looks good, please mark the to-do complete.

Morgan

Jul 10, 2019 at 2:58 PM Notified 7 people

Paul Moon

Harsh

:

The XML uploader is now working well with foreign characters. However, I noticed it no longer reports "last modified" sections as shown below.

image.png 6.83 KB • Download

image.png 19.9 KB • Download

Could you fix this?

Thanks,

Paul

Jul 10, 2019 at 5:16 PM Notified 7 people

Harsh Parikh, Tech Lead

Paul

and

Morgan

,

The issue of Last Modified has resolved on both dev.islg and www.islg. Please check and confirm.

As and example, you can see the XML file UIN No. "BIT/1158" 's modified date is 11/07 now on www.islg.

Jul 11, 2019 at 7:56 AM Notified 7 people

Ryan Knuth, Customer Support Manager

Looks good to me on www.islg. Thanks

Harsh

.

Ryan

Jul 11, 2019 at 12:50 PM Notified 7 people

Ryan Knuth, Customer Support Manager

Harsh

. Sorry, I've just realized the issue still exists on dev.islg. Could you please also push the fix there?

Ryan

Jul 11, 2019 at 12:52 PM Notified 7 people

Harsh Parikh, Tech Lead

Ryan

and

Morgan

,

I have checked on dev.islg and found that the issue has resolved. I have edited one XML and saved it then I can see that last modified date is 11/07.

Could you please share your test case ?

Jul 11, 2019 at 1:21 PM Notified 7 people

Ryan Knuth, Customer Support Manager

Harsh

I had used "BIT/1158" as a test there as well, but I didn't modify the XML. I see the modified info now that I have.

Thanks!

Ryan

Jul 11, 2019 at 1:23 PM Notified 7 people

Paul Moon

Harsh

:

The problem is resolved. I'll mark this complete.

Thank you,

Paul

Jul 12, 2019 at 1:16 PM Notified 7 people

Paul Moon completed this to-do.

Jul 12, 2019 at 1:16 PM